tree 0135631e015cfc32a0b36c505959ee710c78ac65
parent 8e6e7959e49d160ebaebab9a547368248677e504
author Marcel van Lohuizen <mpvl@golang.org> 1611060239 +0100
committer Marcel van Lohuizen <mpvl@golang.org> 1611156755 +0000

internal/core/adt: add support info for trim

This change adds different span types to track
in a closeInfo struct.

A SpanType keeps track how nodes were introduced,
for instance by comprehension, definition, or
constraint.

The added closeInfo nodes also improve error messages.
Previously, only referred structs were adding
position information, but indirectly added structs,
for instance those added by a constraint, did not
result in additional position information.

The information introduced here is intended for
trim, but could very well be useful for other
algorithms.

It is kept as a separate CL, mostly to allow tracking
down performance issues, if such were to arise.
So far the trim refactoring seems to improve
performance, though, because some of the hot
paths have been improved.

Change-Id: I656bad2ced723a1bc54971efbd130711c47a75be
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8237
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Paul Jolly <paul@myitcv.org.uk>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>