)]}' { "commit": "5c2d93798be919fd41b1c7a3625c054faf588331", "tree": "977b8454c104855e7d2cf3f989fe29d934411d1f", "parents": [ "fa59c10ed84bd24f38777b33d48bca18c0bba050" ], "author": { "name": "Marcel van Lohuizen", "email": "mpvl@golang.org", "time": "Thu Nov 07 16:23:32 2019 +0100" }, "committer": { "name": "Marcel van Lohuizen", "email": "mpvl@golang.org", "time": "Thu Nov 07 15:52:40 2019 +0000" }, "message": "cue: don\u0027t turn of manifesting in normalization\n\nThe problem is that the cached results of partially\nevaluated values end can cause spurious \"incomplete\"\nerrors later in evaluation.\n\nThe orignal comment as to why this was done does\nnot (any longer) apply: referenced structs are always\ncopied with a cleared cache. So it is safe to cache the\nvalues now.\n\nChange-Id: Ic79e0231190ca3c2c017a8850d236f01509fbbd7\nReviewed-on: https://cue-review.googlesource.com/c/cue/+/3960\nReviewed-by: Marcel van Lohuizen \u003cmpvl@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "29c50a1a0e4ceeedd5671582472f12e89330c858", "old_mode": 33188, "old_path": "cue/context.go", "new_id": "947987d899e255074b3267e2be834243b329356d", "new_mode": 33188, "new_path": "cue/context.go" }, { "type": "modify", "old_id": "48ff71c51892ca1006aab40a82cf13d6b7c32803", "old_mode": 33188, "old_path": "cue/evaluator.go", "new_id": "703879a8d6fba0fc2f8ff1fa8047cad56fa2b218", "new_mode": 33188, "new_path": "cue/evaluator.go" }, { "type": "modify", "old_id": "d9137021d5104db1d9c747ad816394584aa3e85a", "old_mode": 33188, "old_path": "cue/resolve_test.go", "new_id": "1c3ee9ff18885b4188c33f0d8bc6e6b24285ee8d", "new_mode": 33188, "new_path": "cue/resolve_test.go" }, { "type": "modify", "old_id": "0b7dcd7387344573c170d023d880dba31b3bf03d", "old_mode": 33188, "old_path": "cue/types_test.go", "new_id": "31eb4a6ef16db0acff9c016a7b3a46619a9dc833", "new_mode": 33188, "new_path": "cue/types_test.go" }, { "type": "modify", "old_id": "27aeb7e5b8fe30c4a64ca02367814b24efdf06b8", "old_mode": 33188, "old_path": "cue/value.go", "new_id": "7ad98e7dcc50d2cda980dfd2b6c6f8afc0c66844", "new_mode": 33188, "new_path": "cue/value.go" } ] }