tree 0cdde320a4e5274c7b35f8f6db5b3a3e3d83fa5a
parent b1730b6f8bf3f3c82dc4b2d83141e9b051a89b98
author Tony Worm <1390600+verdverm@users.noreply.github.com> 1617009224 +0200
committer Marcel van Lohuizen <mpvl@golang.org> 1617180995 +0000

cue: add function for Value.Attributes()

First attempt by @verdverm, significant edits by @mpvl.

The API has been designed so that new attribute types can
be added without breaking anything: the user will always
have to explicitly specify the types of attributes that
are needed.

This also adds the NumArgs, Arg, and RawArg methods
to give access to the attribute fields.

This does not handle duplicate attributes. In the future,
there could be merge functionality for this purpose. This
could be done by adding option flags if we can settle on
what constitutes good options.

Original comments from Tony:

This enables a user of the Go API to get all attributes so they
can inspect them, rather than only being able to ask if a particular
attribute exists on a value. Really useful for tools leveraging CUE!

I recall @mpvl might have wanted the return to be a Value or List
rather than the slice?

Closes #529
https://github.com/cuelang/cue/pull/529

GitOrigin-RevId: 6a8951ab75cafe6052fe3b2538aca219f8fa4231
Change-Id: Ie3cc9983656864fa44852b924a3142c82e336f4a
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/9201
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>