tree e63c23a7caa790fde43492525812181815a86b90
parent eb7b60da989013e9701fa062f771ac3ac4bf15f4
author Paul Jolly <paul@myitcv.io> 1615544150 +0000
committer Paul Jolly <paul@myitcv.org.uk> 1615580350 +0000

cmd/cue: fix race in testscript tests that use go/packages

We have recently been seeing a number of test flakes in the
get_go_types.txt which were ultimately reported as golang/go#44137.

However, it turns out this is actually caused by an interaction between
the ./... pattern and use of go/packages within a testscript test,
specifically go/packages (via cmd/go) writing temporary files and
directories to $WORK/tmp which then end up racing with the walk of $WORK
to find directories/packages that match ./...

As of v1.8.0, in a standard testscript setup a temporary directory is
established at $WORK/.tmp. We now follow that same pattern for the home
directory for consistency's sake.

Change-Id: Ia8c7ffd471f9879d3283a47db5f2a5e165f619e1
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/9002
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Paul Jolly <paul@myitcv.org.uk>