tree 41aa489577432c0219929c043c84f1f71eca361f
parent cd286a8e4b63e54835dbbbb3d5e2e1d56848a9d7
author Marcel van Lohuizen <mpvl@golang.org> 1620664658 +0200
committer Marcel van Lohuizen <mpvl@golang.org> 1620715674 +0000

cue/ast/astutil: fix resolution bugs

This fixes several bugs and documentation bugs in
identifier resolution.

1. Resolution in comprehensions would resolve identifiers
to themselves.

2. Label aliases now no longer bind to references outside
the scope of the field. The compiler would catch this invalid
bind and report an error, but it is better not to bind in the
first place.

3. Remove some more mentions of Template labels.

4. Documentation for comprehensions was incorrect
(Scope and Node were reversed).

5. Aliases X in `X=[string]: foo` should only be visible
in foo.

Fixes #946

Change-Id: I3d070e5c67fce55811c1f3fff1e13c38b8d9eeb7
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/9741
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>