tree cc25957d2b37d3f6397975fdeaa12f0949bc1e4e
parent bedb047a988217bab040c29eeb8a51988ce23b76
author Marcel van Lohuizen <mpvl@golang.org> 1612251586 +0100
committer Marcel van Lohuizen <mpvl@golang.org> 1612274551 +0000

internal/core/adt: fix regressions in disjunct elimination

Fix finalization of disjunctions. This bug was introduced
with the latest (critical) performance optimization for
disjunctions and was miraculously not caught by tests.

This also fixes a regression in v0.3 from v0.2 where
cyclic disjunctons were sometimes not fully resolved.

TODO: it probably makes sense to resolve defaults and
disambiguate not considering optionals during the
finalization step of disjunctions. A more concrete
proposal (no pun intended) is in the works.

Fixes #702
Fixes #700

Change-Id: Iae2a1c2a609dfb3a7e9f5ed3d7c6ee5ee17b3e55
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8462
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>