tree 271ba9c82aa07b0e3c9cebace7239e114dc02f39
parent 355cccd265dc14d1e398ec4883f9115d80cc81d2
author Marcel van Lohuizen <mpvl@golang.org> 1610617123 +0100
committer Marcel van Lohuizen <mpvl@golang.org> 1610709170 +0000

internal/core/adt: fix overzealous disambiguation

Equality is used to remove duplicate entries in a disjunction.
However, it did not consider optional fields. This could
lead to differing disjuncts being deleted.

The approach we take is to check that any of the
original StructLits with optional fields are associated
with both Vertices.
Note that it is somewhat okay for Equality to return false
negatives, as the spec does not guarantee this. At some
point we need to come up with something that is
more consistent.

This change leads to a reopening of Issue #353.

Change-Id: I7288061c7d3a51f7a754618c990a14e0275244d0
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8203
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Paul Jolly <paul@myitcv.org.uk>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>