tree 174b055c238394e6809fc6a270409ccf3056c07b
parent c0912749eefb9238c77ced2e173f2a9b8c1e2c4d
author Marcel van Lohuizen <mpvl@golang.org> 1611747393 +0100
committer Marcel van Lohuizen <mpvl@golang.org> 1611852252 +0000

internal/core/adt: fix bottom cycle error

Several problems here

- the evaluation state was not passed properly
- error handling was too aggressive bailing out on a cycle error

The changes are rather subtle, and we really need
a more proper rewrite that is designed specifically
for the new caches, rather than retrofitting the old
algorithm.

Did various related cleanups and also removed a
panic that may appear if the existing code is subtly
changed.

Fixes #667

Change-Id: I7a2f221d727f389ab3aec0b15e399b9c327e9906
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8324
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>